Minor Refactor: Move tab names into a common js file #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did this for only the History, Favourites and Others tabs, kindly review the solution, if I am in the right direction this needs to be done for other tabs too such as : Shabads, Search, Announcements and Dhan-Guru. SImilar thing can be done for overlay screens too. Guide me here. |
|
@yadvirkaur as we discussed this in call, can we instead use the en.json file for constants, instead of a separate file here. |
|
I began with en.json but realised these strings are not user-facing, but are being used for internal logic in code. Using en.json might introduce risks of translation affecting the application's logic. How should we proceed? |
|
Let me think a little on this one, I will get back to you on this in a day or two. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1802
This solution is for the task: "File: MiscHeader.jsx line: 36 we are passing a static string to setTab. Instead, there should be a common js file in constants folder which should have all these tab names and replace that variable in all the files that are using this static string. Not limited to the mentioned line number and file."
Solution: Move all tab names to a new constants file in the constants folder and replace all static string references to tab names across the application with these constants.